Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/puppeth: make it possible to have pw-protected keyfiles #22148

Merged
merged 1 commit into from
Nov 2, 2021
Merged

cmd/puppeth: make it possible to have pw-protected keyfiles #22148

merged 1 commit into from
Nov 2, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jan 8, 2021

This PR makes the ssh connection sequential. This is important in the case where user feedback is needed, e.g. when the ssh key is password protected.

With this PR:

INFO [01-08|11:24:53.385] Administering Ethereum network           name=rinkeby
INFO [01-08|11:24:53.387] Dialing previously configured server     server=karalabe:id_rsa_2017@boot.rinkeby.io
What's the decryption password for /home/user/.ssh/id_rsa_2017? (won't be echoed)
>
INFO [01-08|11:25:00.430] Dialing previously configured server     server=karalabe:id_rsa_2017@web.rinkeby.io
What's the decryption password for /home/user/.ssh/id_rsa_2017? (won't be echoed)
>
INFO [01-08|11:25:06.580] Starting remote server health-check      server=karalabe:id_rsa_2017@web.rinkeby.io
INFO [01-08|11:25:06.580] Starting remote server health-check      server=karalabe:id_rsa_2017@boot.rinkeby.io

Without this PR:

What's the decryption password for /home/user/.ssh/id_rsa_2017? (won't be echoed)
>What's the decryption password for /home/user/.ssh/id_rsa_2017? (won't be echoed)
>

The health-check-phase is still performed in parallel.

@holiman holiman requested a review from karalabe as a code owner January 8, 2021 10:28
@fjl fjl removed the status:triage label Nov 2, 2021
@holiman holiman added this to the 1.10.12 milestone Nov 2, 2021
@holiman holiman merged commit f49e90e into ethereum:master Nov 2, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 2, 2021
@holiman
cmd/puppeth: make it possible to have pw-protected keyfiles (ethereum…
5574c70 
…#22148)
@holiman holiman deleted the wizard_ssh_paralell branch November 10, 2021 18:32
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@holiman @zzyalbert
cmd/puppeth: make it possible to have pw-protected keyfiles (ethereum…
448f194 
…#22148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe Awaiting requested review from karalabe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.12
Development

Successfully merging this pull request may close these issues.
3 participants
@holiman @fjl @ligi